rhbz996388 - move some work after validation is done

zanata · Aug 15, 2013 · ef9cdda · ef9cdda
1 parent bcb89c0
commit ef9cdda
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java b/zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
@@ -89,14 +89,15 @@ public AddReviewCommentResult execute(AddReviewCommentAction action, ExecutionCo
       WorkspaceId workspaceId = action.getWorkspaceId();
       securityServiceImpl.checkWorkspaceStatus(workspaceId);
 
-      HLocale hLocale = localeServiceImpl.getByLocaleId(workspaceId.getLocaleId());
-      TranslationWorkspace workspace = translationWorkspaceManager.getOrRegisterWorkspace(workspaceId);
-
       HTextFlowTarget hTextFlowTarget = textFlowTargetDAO.getTextFlowTarget(action.getTransUnitId().getValue(), workspaceId.getLocaleId());
       if (hTextFlowTarget == null || hTextFlowTarget.getState().isUntranslated())
       {
          throw new ActionException("comment on untranslated message is pointless!");
       }
+
+      HLocale hLocale = localeServiceImpl.getByLocaleId(workspaceId.getLocaleId());
+      TranslationWorkspace workspace = translationWorkspaceManager.getOrRegisterWorkspace(workspaceId);
+
       HTextFlowTargetReviewComment hComment = hTextFlowTarget.addReviewComment(action.getContent(), authenticatedAccount.getPerson());
       textFlowTargetDAO.makePersistent(hTextFlowTarget);
       textFlowTargetDAO.flush();