Refactor LocaleServiceImpl.getByLocaleId(String) for brevity.

zanata · Jun 4, 2015 · f643587 · f643587
1 parent 0a4e2c5
commit f643587
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/service/impl/LocaleServiceImpl.java b/zanata-war/src/main/java/org/zanata/service/impl/LocaleServiceImpl.java
@@ -266,14 +266,12 @@ public HLocale getByLocaleId(@Nonnull LocaleId locale) {
     @Override
     @Nullable
     public HLocale getByLocaleId(@Nonnull String localeId) {
-        final LocaleId locale;
         try {
-            locale = new LocaleId(localeId);
+            return this.getByLocaleId(new LocaleId(localeId));
         } catch (IllegalArgumentException e) {
             log.warn("Tried to look up a locale with a malformed id", e);
             return null;
         }
-        return this.getByLocaleId(locale);
     }
 
     @Override