rhbz983370 show correct parent checkbox state on page refresh/reload

zanata · Jul 12, 2013 · fd60b69 · fd60b69
1 parent 6c0eea5
commit fd60b69
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransFilterDisplay.java b/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransFilterDisplay.java
@@ -21,7 +21,7 @@ public interface TransFilterDisplay extends WidgetDisplay, SearchFieldListener
    void setNeedReviewFilter(boolean filterByNeedReview);
 
    void setUntranslatedFilter(boolean filterByUntranslated);
-   
+
    void setApprovedFilter(boolean filterByApproved);
 
    void setRejectedFilter(boolean filterByRejected);

diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransFilterView.java b/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransFilterView.java
@@ -116,37 +116,43 @@ public void setSearchTerm(String searchTerm)
    @Override
    public void setUntranslatedFilter(boolean filterByUntranslated)
    {
-      untranslatedChk.setValue(filterByUntranslated);
+      updateChildCheckbox(untranslatedChk, filterByUntranslated);
    }
 
    @Override
    public void setNeedReviewFilter(boolean filterByNeedReview)
    {
-      fuzzyChk.setValue(filterByNeedReview);
+      updateChildCheckbox(fuzzyChk, filterByNeedReview);
    }
 
    @Override
    public void setTranslatedFilter(boolean filterByTranslated)
    {
-      translatedChk.setValue(filterByTranslated);
+      updateChildCheckbox(translatedChk, filterByTranslated);
    }
 
    @Override
    public void setApprovedFilter(boolean filterByApproved)
    {
-      approvedChk.setValue(filterByApproved);
+      updateChildCheckbox(approvedChk, filterByApproved);
    }
 
    @Override
    public void setRejectedFilter(boolean filterByRejected)
    {
-      rejectedChk.setValue(filterByRejected);
+      updateChildCheckbox(rejectedChk, filterByRejected);
    }
 
    @Override
    public void setHasErrorFilter(boolean filterByHasError)
    {
-      hasErrorChk.setValue(filterByHasError);
+      updateChildCheckbox(hasErrorChk, filterByHasError);
+   }
+
+   private void updateChildCheckbox(CheckBox checkbox, boolean value)
+   {
+      checkbox.setValue(value);
+      updateParentCheckboxes();
    }
 
    @Override