Implement redirect to dashboard after login #104
Conversation
alex-sl-eng
commented
Aug 8, 2013
alex-sl-eng
commented
- Implement redirect to dashboard after login, if its to redirect to home page
- Add 'Dashboard' link on top menu when user logged in
…me page), add 'Dashboard' link on top menu when user logged in
ghost
assigned 
| if(userRedirect.isRedirect() && !userRedirect.isRedirectToHome()) | ||
| { | ||
| return "redirect"; | ||
| } | ||
| } | ||
| return "dashboard"; |
There was a problem hiding this comment.
This new "dashboard" value should be up in the comments.
There was a problem hiding this comment.
Better still, all these magic strings could be encapsulated in an enumeration - that would make it impossible to add another one without adding it to the reference location. Presumably if .oString() is overridden, seam would still get the string, and there would be some concrete identifiers to attach javadoc.
There was a problem hiding this comment.
That is a nice refactoring that we can look into later as it is larger than that. In order to take full advantage of an enumerated value we need to refactor a few methods accesed in pages.xml and a few other places.
I am all for using more enumerations... I like type strength.
|
👍 after that minor documentation change it should be good to go. |
|
@davidmason Are you happy to go through with this merge without the enumeration? |
|
@carlosmunoz Should be fine without adding an enum yet - it's no worse than it was before the change. If we intend to use an enum eventually we could add a TODO, but I don't think it's a big deal. |
Implement redirect to dashboard after login
