Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

fix(glossary details): update glossary link in details page #1308

Merged
merged 2 commits into from Oct 4, 2016

Conversation

alex-sl-eng
Copy link
Member

@alex-sl-eng alex-sl-eng commented Sep 30, 2016

JIRA issue URL: [paste URL here]

[Add a short description of what is changed here.]

Reviewer tasks

The following is based on the
Zanata Development Guidelines.
As a reviewer, you should check the guidelines regularly for updates, and just
to refresh your memory.

The reviewer can use this list for reference to make sure
they have considered all the important points.

Use the checkboxes or not, whatever works best for you.

  • Code quality
    • Code passes style check (checkstyle/eslint)
    • Code is clear and concise
    • UI code is internationalised
    • Code has adequate comments where appropriate
    • Code is in an appropriate place
      • Classes are in appropriate packages
      • Code fits with class's responsibilities (SRP)
    • Configuration files are documented enough
    • If code is removed
      • No remaining code references the removed code
        • No orphaned rewrite rules
      • No orphaned config settings
      • No remaining comments refer to the removed code
      • Unused imports and libraries are removed
  • Testing
    • New code has tests
    • Changed code has tests
    • All tests pass
    • Test coverage stable or increased
  • Documentation
    • New features are documented
    • Docs removed for deleted features
    • Docs updated for all changed features
    • Developer/sysadmin docs updated if appropriate
  • If there are new dependencies

This template can be updated in .github/PULL_REQUEST_TEMPLATE.md

https://zanata.atlassian.net/browse/ZNTA-1406


This change is Reviewable

@huangp
Copy link
Collaborator

huangp commented Sep 30, 2016

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


zanata-war/src/main/java/org/zanata/util/UrlUtil.java, line 353 at r1 (raw file):

        boolean hasFilter = StringUtils.isNotBlank(filter);
        if (hasFilter) {
            url += "?filter=" + filter;

I remember in the demo the filter is not encoded. Do you need to encode it here? Also it's better to have some unit tests for various cases.


Comments from Reviewable

@huangp
Copy link
Collaborator

huangp commented Sep 30, 2016

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@huangp
Copy link
Collaborator

huangp commented Sep 30, 2016

:lgtm: -(Awaiting review) +Reviewed +(On QA)


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@djansen-redhat
Copy link
Contributor

✅ tested

@alex-sl-eng alex-sl-eng merged commit 104122f into master Oct 4, 2016
@alex-sl-eng alex-sl-eng deleted the ZNTA-1406-glossary-edit branch October 4, 2016 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants