Fix workflow in 'Find User to Add Dialog' in language team : https://bugzilla.redhat.com/show_bug.cgi?id=998825 #138
Conversation
| public boolean isCoordinator() | ||
| { | ||
| return isCoordinator; | ||
| this.selected = true; //user needs to be selected when a role is selected |
There was a problem hiding this comment.
This looks like it will also select the user when the role is un-selected. I think each role would need to call a method like:
private void refreshSelected()
{
selected = isReviewer || isTranslator || isCoordinator;
}
|
The xml looks like it has a mix of 2 and 4 space indentation, might be good to keep it consistent. |
|
just asking. Do we need a selected checkbox if any role checked will trigger the selection? Until we enable language observer type of member(not translator, not reviewer, not coordinator), there seems to be no need to have a selected checkbox there which just confuses user. |
|
@huangp Good point. I think it is good to show that a user is selected, but maybe the role checkboxes are sufficient for that. I would prefer to just have a subtle highlight on the row when selected == true |
|
Logic looks good. Please format the java code, and fix the mixed tabs & spaces in the xml. |
| <rich:dataTable id="threads" value="#{languageTeamAction.localeMembers}" | ||
| var="member" rendered="#{not empty languageTeamAction.locale.members}" | ||
| sortMode="single"> | ||
| <rich:column id="usernameCol" width="auto" sortBy="#{member.person.account.username}" sortOrder="ascending"> |
There was a problem hiding this comment.
The formatting in this file seems all messed up now, maybe due to mixed spaces and tabs? For this file I think it would be best to roll bask the formatting changes and just manually convert the spaces to tabs in the few parts that were edited.
|
👍 |
Fix workflow in 'Find User to Add Dialog' in language team : https://bugzilla.redhat.com/show_bug.cgi?id=998825
As described in https://bugzilla.redhat.com/show_bug.cgi?id=998825
when a person is selected, "Translator" role is enabled by default
when a role is selected, that entry (first column) will be selected as well.