New project and version page #399

alex-sl-eng · 2014-03-17T06:56:10Z

https://bugzilla.redhat.com/show_bug.cgi?id=1066796

alex-sl-eng · 2014-03-17T08:37:34Z

@huangp, please review this.

alex-sl-eng · 2014-03-17T22:24:52Z

huangp · 2014-03-17T23:03:57Z

functional-test/src/main/java/org/zanata/page/projects/ProjectPage.java

+                        .findElement(
+                                By.id("settings-permissions-form:maintainerAutocomplete:maintainerAutocomplete-result"))
+                        .findElements(
+                                By.xpath(".//ul[@class='autocomplete__results']/li"));


Looks like now we heavily rely on css class and xpath to locate elements on page. A bit worry in turns of performance and maintenance. But I don't know if there is a better way to address this @djansen-redhat . For this specific method, I will suggest extract the By.xpath(".//ul[@Class='autocomplete__results']/li") object to either an instance field or local variable or even a field in BasePage/AbstractPage if this is common for all search auto complete. Or extract the whole search auto complete as a static method in WebElementUtil.

…i?id=1066796 Squashed commit of the following: commit 655a81f Merge: 1e0829a 6724cf1 Author: Alex Eng <aeng@redhat.com> Date: Mon Mar 24 15:21:08 2014 +1000 Merge branch 'integration/master' into project-page commit 1e0829a Author: Alex Eng <aeng@redhat.com> Date: Mon Mar 24 15:20:40 2014 +1000 fix functional test commit 8b1a798 Author: Alex Eng <aeng@redhat.com> Date: Mon Mar 24 15:19:22 2014 +1000 new global message in template.xhtml commit 4186053 Author: Alex Eng <aeng@redhat.com> Date: Mon Mar 24 13:18:12 2014 +1000 fix flash scope messages, remove invalid '>' in 'No language in this version' note commit efbf11c Merge: 19e9a95 c1c04a2 Author: Alex Eng <aeng@redhat.com> Date: Fri Mar 21 11:23:20 2014 +1000 Merge branch 'integration/master' into project-page Conflicts: zanata-war/src/main/webapp/WEB-INF/layout/version-group/languages-tab.xhtml zanata-war/src/main/webapp/WEB-INF/layout/version-group/projects-tab.xhtml zanata-war/src/main/webapp/WEB-INF/layout/version-group/settings-tab.xhtml zanata-war/src/main/webapp/resources/script/components-script.js zanata-war/src/main/webapp/version-group/version_group.xhtml commit 19e9a95 Author: Alex Eng <aeng@redhat.com> Date: Fri Mar 21 08:59:12 2014 +1000 fix checkstyle commit c3d40f0 Author: Alex Eng <aeng@redhat.com> Date: Fri Mar 21 07:35:27 2014 +1000 Fix document list not update after delete commit 7191963 Author: Alex Eng <aeng@redhat.com> Date: Thu Mar 20 16:56:55 2014 +1000 WIP: document update commit 716a96c Author: Alex Eng <aeng@redhat.com> Date: Thu Mar 20 11:47:04 2014 +1000 Add loading icon on right panel, changed of badge to label for text commit 7ce92e1 Author: Alex Eng <aeng@redhat.com> Date: Wed Mar 19 00:09:06 2014 +1000 Handle disabled locale in list commit 7d818bc Author: Alex Eng <aeng@redhat.com> Date: Tue Mar 18 16:18:09 2014 +1000 Redirect source files and files url to version's document tab commit c58ecb1 Author: Alex Eng <aeng@redhat.com> Date: Tue Mar 18 13:36:05 2014 +1000 Move repeated comparator to ComparatorUtil collection commit 1b11eb9 Author: Alex Eng <aeng@redhat.com> Date: Tue Mar 18 12:23:38 2014 +1000 Refactor code according to review comments commit 14412c0 Author: Alex Eng <aeng@redhat.com> Date: Tue Mar 18 08:01:38 2014 +1000 Refactor list-filter component commit 2524ba4 Author: Alex Eng <aeng@redhat.com> Date: Mon Mar 17 16:54:41 2014 +1000 New project and version page: https://bugzilla.redhat.com/show_bug.cgi?id=1066796

carlosmunoz · 2014-03-25T23:32:39Z

@aeng Not sure if you are aware this is failing tests.

carlosmunoz · 2014-03-26T00:11:39Z

functional-test/src/main/java/org/zanata/page/CorePage.java

+     * Shift focus to the page, in order to activate some elements that only
+     * exhibit behaviour on losing focus. Some pages with contained objects
+     * cause object behaviour to occur when interacted with, so in this case
+     * interact with the container instead.


Lets try to avoid these changes, they waste time specially on long pull requests.

auto format causing this.

Projects and ProjectVersions have changed significantly and the previous test suite was somewhat conceptually outdated. Move settings pages to tabs. Add some project tests. Seperate projects and versions.

carlosmunoz · 2014-03-26T04:48:43Z

zanata-war/src/main/java/org/zanata/action/ProjectSearch.java

    @In
    private ZanataIdentity identity;

+    @Getter
+    private final AbstractAutocomplete<SearchResult> projectAutocomplete =
+            new AbstractAutocomplete<SearchResult>() {


Might be more readable to not have this as an anonymous class, even if it's just a nested one.

…roject-page

carlosmunoz · 2014-03-26T05:29:49Z

zanata-war/src/main/java/org/zanata/action/VersionHome.java

+        if (flashScopeMessage == null) {
+            flashScopeMessage = FlashScopeMessage.instance();
+        }
+        return flashScopeMessage;


I just noticed this method which happens to be in several other classes. Why fetch the component when you are injecting it? Seems to break the whole inversion of control paradigm.

huangp · 2014-03-31T01:13:16Z

zanata-war/src/main/java/org/zanata/ui/FilterUtil.java

+        Collection<HPerson> filtered =
+                Collections2.filter(unfiltered, new Predicate<HPerson>() {
+                    @Override
+                    public boolean apply(@Nullable HPerson input) {


huangp · 2014-03-31T03:24:08Z

zanata-war/src/test/java/org/zanata/model/HTextFlowTargetHistoryJPATest.java

    }

    @SuppressWarnings("unchecked")
    private List<HTextFlowTargetHistory> getHistory(HTextFlowTarget tft) {
        return getSession().createCriteria(HTextFlowTargetHistory.class)
-                .add(Restrictions.eq("textFlowTarget", tft)).list();
+            .add(Restrictions.eq("textFlowTarget", tft)).list();


This file needs to reformat

Significant changes to the structure and behaviour of project and version tests.

djansen-redhat · 2014-04-03T05:36:01Z

@Jenkins retest this please

davidmason · 2014-04-03T06:19:18Z

@Jenkins retest this please

seanf · 2014-04-03T07:40:59Z

If you merge in the latest master, there's a fix for the test GetLocaleListHandlerTest.testExecuteWithOverriddenIterationLocales.

Conflicts: zanata-war/src/main/java/org/zanata/action/ViewAllStatusAction.java zanata-war/src/main/webapp/resources/script/components-script.js zanata-war/src/test/java/org/zanata/webtrans/server/rpc/GetLocaleListHandlerTest.java

alex-sl-eng · 2014-04-04T06:06:35Z

Just curious, why we are doing refactoring in midst of development? Won't this only cause unnecessary conflicts?

alex-sl-eng · 2014-04-04T06:13:11Z

@Jenkins retest this please

alex-sl-eng · 2014-04-06T22:59:06Z

@Jenkins retest this please

alex-sl-eng · 2014-04-06T23:22:16Z

@Jenkins retest this please

seanf · 2014-04-07T00:20:51Z

On 2014-04-04 16:06, Alex Eng wrote:

Just curious, why we are doing refactoring in midst of development?
Won't this cause unnecessary conflicts?

We're always in the midst of development! I didn't know you would be
working on the same file.

The old test was broken because it was testing the order of an unordered
collection, which changed its order for some reason. The correct fix
was to use an order-ignoring comparison (I think you missed that in your
version), which I found easier to do in AssertJ.

Even if I had fixed the order testing using Hamcrest, there would have
been a conflict on that file.

Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat

This message has changed, but will change again in a different pull request. Removed the test assert for it.

djansen-redhat · 2014-04-09T02:18:07Z

I think I've beaten this request enough.
👍

New project and version page

alex-sl-eng assigned huangp Mar 17, 2014

huangp reviewed Mar 17, 2014
View reviewed changes

Refactor activity query for project

0ac0918

carlosmunoz reviewed Mar 26, 2014
View reviewed changes

djansen-redhat added 2 commits March 26, 2014 12:42

Restructure Project and Version testing

9296f5a

Projects and ProjectVersions have changed significantly and the previous test suite was somewhat conceptually outdated. Move settings pages to tabs. Add some project tests. Seperate projects and versions.

Add missing EOF newlines.

862feee

carlosmunoz reviewed Mar 26, 2014
View reviewed changes

Alex Eng added 2 commits March 26, 2014 15:06

Refactor and fixes on review

293dbaf

Merge branch 'project-page' of github.com:zanata/zanata-server into p…

cc5101e

…roject-page

carlosmunoz reviewed Mar 26, 2014
View reviewed changes

huangp reviewed Mar 31, 2014
View reviewed changes

fix download all documents permission, fix line format indentation

55b7b1c

huangp reviewed Mar 31, 2014
View reviewed changes

Alex Eng and others added 6 commits March 31, 2014 15:12

Reformat file: HTextFlowTargetHistoryJPATest

956e2ae

Fix project type selection in create project page

9548f64

fix project type in create project page

0f1be8c

Update global message class

a6434a2

Merge branch 'integration/master' into project-page

b60a800

Add new Project / Version tests

5c7e7d7

Significant changes to the structure and behaviour of project and version tests.

Alex Eng and others added 4 commits April 4, 2014 09:22

Fix and move getVersionSupportedLocale test to service class

78e782a

Merge branch 'integration/master' into project-page

35ab5a3

Conflicts: zanata-war/src/main/java/org/zanata/action/ViewAllStatusAction.java zanata-war/src/main/webapp/resources/script/components-script.js zanata-war/src/test/java/org/zanata/webtrans/server/rpc/GetLocaleListHandlerTest.java

Remove window resize

9b133e8

Reapply AssertJ refactoring

f9e241c

Fix functional test

33c275c

djansen-redhat and others added 2 commits April 7, 2014 14:52

Remove obsolete notification assert on upload file test

18e8f56

This message has changed, but will change again in a different pull request. Removed the test assert for it.

Scale down statistic loading of documents in version page

aafa242

djansen-redhat added a commit that referenced this pull request Apr 9, 2014

Merge pull request #399 from zanata/project-page

907ce45

New project and version page

djansen-redhat merged commit 907ce45 into integration/master Apr 9, 2014

djansen-redhat deleted the project-page branch April 9, 2014 02:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New project and version page #399

New project and version page #399

alex-sl-eng commented Mar 17, 2014

alex-sl-eng commented Mar 17, 2014

alex-sl-eng commented Mar 17, 2014

huangp Mar 17, 2014

carlosmunoz commented Mar 25, 2014

carlosmunoz Mar 26, 2014

alex-sl-eng Mar 26, 2014

carlosmunoz Mar 26, 2014

carlosmunoz Mar 26, 2014

huangp Mar 31, 2014

huangp Mar 31, 2014

djansen-redhat commented Apr 3, 2014

davidmason commented Apr 3, 2014

seanf commented Apr 3, 2014

alex-sl-eng commented Apr 4, 2014

alex-sl-eng commented Apr 4, 2014

alex-sl-eng commented Apr 6, 2014

alex-sl-eng commented Apr 6, 2014

seanf commented Apr 7, 2014

djansen-redhat commented Apr 9, 2014

New project and version page #399

New project and version page #399

Conversation

alex-sl-eng commented Mar 17, 2014

alex-sl-eng commented Mar 17, 2014

alex-sl-eng commented Mar 17, 2014

huangp Mar 17, 2014

Choose a reason for hiding this comment

carlosmunoz commented Mar 25, 2014

carlosmunoz Mar 26, 2014

Choose a reason for hiding this comment

alex-sl-eng Mar 26, 2014

Choose a reason for hiding this comment

carlosmunoz Mar 26, 2014

Choose a reason for hiding this comment

carlosmunoz Mar 26, 2014

Choose a reason for hiding this comment

huangp Mar 31, 2014

Choose a reason for hiding this comment

huangp Mar 31, 2014

Choose a reason for hiding this comment

djansen-redhat commented Apr 3, 2014

davidmason commented Apr 3, 2014

seanf commented Apr 3, 2014

alex-sl-eng commented Apr 4, 2014

alex-sl-eng commented Apr 4, 2014

alex-sl-eng commented Apr 6, 2014

alex-sl-eng commented Apr 6, 2014

seanf commented Apr 7, 2014

djansen-redhat commented Apr 9, 2014