This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Make sure csrf tokens match on client and server. #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +82,7 @@ public void onFailure(final Throwable caught) { | |||
| } | |||
| if (caught instanceof AuthenticationError | |||
| || caught instanceof InvalidTokenError) { | |||
| Log.error("Invalid Token error ("+ sessionId + ")", caught); | |||
There was a problem hiding this comment.
I think we should split these two conditions, and have separate log messages for each.
|
@seanf Ready for a second round of reviewing. |
|
Looks good. |
|
@definite Do you mind testing this one? |
|
@zanata-jenkins retest this please |
|
✅ Looks good to me |
djansen-redhat
added a commit
that referenced
this pull request
Jul 23, 2014
Make sure csrf tokens match on client and server.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an improvement when loading up the web editor. In some scenarios, the editor would not detect an authenticated user and would redirect to the login page, which in turn would redirect to the dashboard. This pull request corrects this.