Skip to content
This repository has been archived by the owner. It is now read-only.

Use JNDI to obtain mail server from app server #633

Closed
wants to merge 3 commits into from

Conversation

@seanf
Copy link
Contributor

@seanf seanf commented Nov 10, 2014

In EAP 6, the mail server configuration can be controlled with mail-session in the mail subsystem, and with an outbound-socket-binding in socket-binding-group. This is used to configure the mail session available through JNDI as java:jboss/mail/Default and this is the config which can be used to enable JavaMelody's email features.

Switching Zanata to use the JNDI mail session (in components.xml) avoids the need to configure the mail server twice, and also allows the app server admin to change the mail server setup without going into Zanata's admin screens.

@@ -134,6 +134,7 @@
<property name="name">Administrator</property>
</component>

<mail:mail-session session-jndi-name="java:jboss/mail/Default" />
Copy link
Member

@carlosmunoz carlosmunoz Nov 12, 2014

Should we give this a Zanata specific name?

Copy link
Contributor Author

@seanf seanf Nov 12, 2014

I'd rather use the one that's built into EAP, which defaults to localhost:25 from memory.

@carlosmunoz
Copy link
Member

@carlosmunoz carlosmunoz commented Nov 12, 2014

👍 Reviewed

@seanf
Copy link
Contributor Author

@seanf seanf commented Dec 15, 2014

@carlosmunoz Should I merge this, or is the documentation change still outstanding?

@seanf
Copy link
Contributor Author

@seanf seanf commented Dec 15, 2014

@seanf seanf added the On QA label Dec 19, 2014
@seanf seanf assigned djansen-redhat and unassigned carlosmunoz Dec 19, 2014
@djansen-redhat
Copy link
Contributor

@djansen-redhat djansen-redhat commented Dec 22, 2014

@zanata-jenkins retest this please

@djansen-redhat
Copy link
Contributor

@djansen-redhat djansen-redhat commented Dec 22, 2014

I encountered an error when sending an email to the administrator via the Help page - I may be testing it wrong, not sure.

Also: http://i.imgur.com/jdLcSKP.png

@seanf
Copy link
Contributor Author

@seanf seanf commented Jan 13, 2015

@djansen-redhat Have you got the standalone.xml you were using in the email test? And which platform was the server on?

@djansen-redhat
Copy link
Contributor

@djansen-redhat djansen-redhat commented Jan 14, 2015

@seanf Unfortunately not. I am using Fedora 20.

@djansen-redhat
Copy link
Contributor

@djansen-redhat djansen-redhat commented Jan 21, 2015

@zanata-jenkins retest this please

@seanf seanf force-pushed the use-jndi-for-mail branch from 45812b8 to 3de7079 Feb 6, 2015
@seanf seanf force-pushed the use-jndi-for-mail branch from 3de7079 to a9a4d41 Apr 1, 2015
@seanf
Copy link
Contributor Author

@seanf seanf commented Apr 1, 2015

@djansen-redhat Is there anything I can do to help with this one?

Conflicts:
	zanata-war/src/main/java/org/zanata/ApplicationConfiguration.java
	zanata-war/src/main/java/org/zanata/config/JndiBackedConfig.java
@alex-sl-eng
Copy link
Member

@alex-sl-eng alex-sl-eng commented May 21, 2015

@zanata-jenkins retest this please

@djansen-redhat
Copy link
Contributor

@djansen-redhat djansen-redhat commented May 25, 2015

Tested, looks fine

@seanf
Copy link
Contributor Author

@seanf seanf commented May 25, 2015

@aeng what happened to the contents of https://github.com/zanata/zanata-server/wiki/Email ? I had information in there about the new way of configuring email.

@seanf
Copy link
Contributor Author

@seanf seanf commented May 25, 2015

@djansen-redhat @aeng I found the missing information in the wiki history, and added it to the admin guide.

@seanf seanf force-pushed the use-jndi-for-mail branch from ea5dd44 to a7d082e May 25, 2015
@seanf
Copy link
Contributor Author

@seanf seanf commented May 25, 2015

@djansen-redhat Please look at my changes for the release notes and the sysadmin docs.

@seanf seanf removed the Reviewed label May 25, 2015
@alex-sl-eng
Copy link
Member

@alex-sl-eng alex-sl-eng commented May 25, 2015

@seanf Can you please update in docs.zanata.org for the email config?

@djansen-redhat
Copy link
Contributor

@djansen-redhat djansen-redhat commented May 25, 2015

@aeng @seanf I might give this another go-through before we merge, I could have tested it better

@seanf
Copy link
Contributor Author

@seanf seanf commented May 26, 2015

@djansen-redhat so you reviewed the docs changes again?

@djansen-redhat
Copy link
Contributor

@djansen-redhat djansen-redhat commented May 26, 2015

@seanf yes

seanf added a commit that referenced this issue May 26, 2015
#633

Squashed commit of the following:

commit a7d082e
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Mon May 25 16:15:47 2015 +1000

    Update release notes and docs for mail config

commit 2ea59a0
Merge: a9a4d41 73a9960
Author: Alex Eng <aeng@redhat.com>
Date:   Thu May 21 09:36:39 2015 +1000

    Merge branch 'integration/master' into use-jndi-for-mail

    Conflicts:
    	zanata-war/src/main/java/org/zanata/ApplicationConfiguration.java
    	zanata-war/src/main/java/org/zanata/config/JndiBackedConfig.java

commit a9a4d41
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Mon Nov 10 17:34:26 2014 +1000

    Use JNDI to obtain mail server from app server
@seanf
Copy link
Contributor Author

@seanf seanf commented May 26, 2015

Merged as 3991bfa.

@seanf seanf closed this May 26, 2015
@seanf seanf deleted the use-jndi-for-mail branch May 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants