Use JNDI to obtain mail server from app server #633
Conversation
| @@ -134,6 +134,7 @@ | |||
| <property name="name">Administrator</property> | |||
| </component> | |||
|
|
|||
| <mail:mail-session session-jndi-name="java:jboss/mail/Default" /> | |||
There was a problem hiding this comment.
Should we give this a Zanata specific name?
There was a problem hiding this comment.
I'd rather use the one that's built into EAP, which defaults to localhost:25 from memory.
|
👍 Reviewed |
|
@carlosmunoz Should I merge this, or is the documentation change still outstanding? |
|
@zanata-jenkins retest this please |
|
I encountered an error when sending an email to the administrator via the Help page - I may be testing it wrong, not sure. |
|
@djansen-redhat Have you got the |
|
@seanf Unfortunately not. I am using Fedora 20. |
|
@zanata-jenkins retest this please |
seanf
force-pushed
the
use-jndi-for-mail
branch
from
45812b8
to
3de7079
Compare
|
@djansen-redhat Is there anything I can do to help with this one? |
Conflicts: zanata-war/src/main/java/org/zanata/ApplicationConfiguration.java zanata-war/src/main/java/org/zanata/config/JndiBackedConfig.java
|
@zanata-jenkins retest this please |
|
✅ Tested, looks fine |
|
@aeng what happened to the contents of https://github.com/zanata/zanata-server/wiki/Email ? I had information in there about the new way of configuring email. |
|
@djansen-redhat @aeng I found the missing information in the wiki history, and added it to the admin guide. |
|
@djansen-redhat Please look at my changes for the release notes and the sysadmin docs. |
|
@seanf Can you please update in docs.zanata.org for the email config? |
|
@djansen-redhat so you reviewed the docs changes again? |
|
@seanf yes |
#633 Squashed commit of the following: commit a7d082e Author: Sean Flanigan <sflaniga@redhat.com> Date: Mon May 25 16:15:47 2015 +1000 Update release notes and docs for mail config commit 2ea59a0 Merge: a9a4d41 73a9960 Author: Alex Eng <aeng@redhat.com> Date: Thu May 21 09:36:39 2015 +1000 Merge branch 'integration/master' into use-jndi-for-mail Conflicts: zanata-war/src/main/java/org/zanata/ApplicationConfiguration.java zanata-war/src/main/java/org/zanata/config/JndiBackedConfig.java commit a9a4d41 Author: Sean Flanigan <sflaniga@redhat.com> Date: Mon Nov 10 17:34:26 2014 +1000 Use JNDI to obtain mail server from app server
|
Merged as 3991bfa. |
In EAP 6, the mail server configuration can be controlled with
mail-sessionin themailsubsystem, and with anoutbound-socket-bindinginsocket-binding-group. This is used to configure the mail session available through JNDI asjava:jboss/mail/Defaultand this is the config which can be used to enable JavaMelody's email features.Switching Zanata to use the JNDI mail session (in
components.xml) avoids the need to configure the mail server twice, and also allows the app server admin to change the mail server setup without going into Zanata's admin screens.