This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Fix input field not save when using same text as placeholder: https://bu... #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
✅ Tested. Build has also passed but not reflected here correctly. |
|
Merged into release. 4be04f5 |
|
@aeng it looks like the only code changes are layout changes and a variable name. Does this really do what the title says? |
|
@davidmason Not exactly. The major issue is using the actual Zanata ToU url in a placeholder will cause our current system to break. |
|
There is a fix on the branch I am working in that will separate placeholder text into an attribute properly, so we should be able to fix the field once that is merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1185134