Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

disable rendering in filter list if empty string #687

Closed
wants to merge 1 commit into from
Closed

disable rendering in filter list if empty string #687

wants to merge 1 commit into from

Conversation

alex-sl-eng
Copy link
Member

@huangp
Copy link
Collaborator

huangp commented Feb 11, 2015

👍

@djansen-redhat
Copy link
Contributor

  • Spaces actually affect the behaviour (i.e. will filter for documents with a space) so using trim() breaks the Cancel if the user entered a space. I suggest Cancel clears the field if there is anything in there and reloads the list if it had to.

@djansen-redhat
Copy link
Contributor

✅ Tested

@alex-sl-eng
Copy link
Member Author

Merged into integration/master. 51fd4b3

@alex-sl-eng alex-sl-eng deleted the rhbz1190557 branch February 12, 2015 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Verified
Projects
None yet
Milestone
No milestone
3 participants
@alex-sl-eng @huangp @djansen-redhat