This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Implement email reasons for admin #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,16 +139,21 @@ public String sendPasswordResetEmail(HPerson person, String key) { | |||
| } | |||
|
|
|||
| @Override | |||
| public String sendToAdmins(EmailStrategy strategy) { | |||
| public String sendToAdmins(EmailStrategy strategy, | |||
There was a problem hiding this comment.
Lets comment what received reasons are and how they will be used.
|
👍 with the documentation additions. |
| @@ -1168,6 +1168,8 @@ jsf.email.admin.UserMessageIntro=Zanata user "{0}" with id "{1}" has sent the fo | |||
| jsf.email.ReplyInstructions=You can reply to {0} at {1} | |||
| jsf.email.admin.ReceivedReason=You are an administrator in the system configuration | |||
| jsf.email.admin.user.ReceivedReason=You are an administrator | |||
| jsf.email.admin.ReceivedReason.language.noCoordinator=There is no coordinator for language "{0} ({1})" | |||
| jsf.email.admin.ReceivedReason.versionGroup.noMaintainer=There is no maintainer for version group "{0}" | |||
There was a problem hiding this comment.
Suggest:
- This message is intended for the language coordinators of {0} ({1}). No coordinators are assigned to {0} so this will be sent to server administrators instead.
- This message is intended for the maintainers of version group "{0}". No maintainers are assigned to version group "{0}" so this will be sent to server administrators instead.
There was a problem hiding this comment.
I doubt anyone will actually read message this long. Personally I prefer short and simple.
|
|
👍 |
alex-sl-eng
pushed a commit
that referenced
this pull request
Mar 3, 2015
Implement email reasons for admin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1197572