This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Ensure that a success message is shown when project about page is updated #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -290,6 +290,8 @@ jsf.languageSettings.LanguagesDisabled=Disabled languages: {0}. | |||
| jsf.languageSettings.LanguageEnabled=Language "{0}" has been enabled. | |||
| jsf.languageSettings.LanguagesEnabled=Enabled languages: {0}. | |||
| jsf.project.LanguageUpdateFromGlobal=Updated languages from global settings. | |||
| jsf.project.AboutPageUpdated=About page updated. | |||
| jsf.project.AboutPageUpdateFailed=There was a problem while updating the about page. | |||
There was a problem hiding this comment.
If there was an error, I don't have any way here to know whether it was updated or not.
In practice the case where this message would be displayed may never come up - I think it would redirect to the error page if there was an exception, and the library code looks like it is hard-coded to indicate success (so an exception is the only way that it would not indicate success to my code).
There was a problem hiding this comment.
Ah, so it could have been updated?
There was a problem hiding this comment.
@djansen-redhat yes - basically if that message is displayed, the state is unknown to the code.
|
👍 |
davidmason
added a commit
that referenced
this pull request
Mar 5, 2015
Ensure that a success message is shown when project about page is updated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to use the default "Successfully updated" message, but that has been overridden.