This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
WIP: raw file migration from database to file system #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts:
zanata-war/src/main/java/org/zanata/file/GlobalDocumentId.java
lombok annotations added in remote, toString added in local.
kept changes from remote + toString method.
| @@ -54,6 +54,7 @@ | |||
| private static final String KEY_AUTH_POLICY = "java:global/zanata/security/auth-policy-names/"; | |||
| private static final String KEY_ADMIN_USERS = "java:global/zanata/security/admin-users"; | |||
| private static final String KEY_DEFAULT_FROM_ADDRESS = "java:global/zanata/email/default-from-address"; | |||
| private static final String KEY_DOCUMENT_FILE_STORE = "java:global/zanata/files/document-storage"; | |||
There was a problem hiding this comment.
I'm not sure about this name, but I don't think it's that big a deal. Thoughts?
There was a problem hiding this comment.
What is it? A directory name? Might be a good idea to include that in the name.
|
Looks good. 👍 |
seanf
added a commit
that referenced
this pull request
Jul 26, 2013
WIP: raw file migration from database to file system
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See specific comments below for review.