rhbz1048293 Fix liquibase changeset to be compatible with mysql/mariadb version > 5.5 #756
Conversation
| <addPrimaryKey tableName="HTermComment" columnNames="id" /> | ||
| <addForeignKeyConstraint baseTableName="HGlossaryTerm" | ||
| baseColumnNames="glossaryEntryId" constraintName="UKglossaryterm_glossary_entry_id" | ||
| referencedTableName="HGlossaryEntry" referencedColumnNames="id" /> |
There was a problem hiding this comment.
Can you add an xml comment with the reason for removing then adding the keys and constraints? I assume that the addAutoIncrement lines cannot be applied while the keys and constraints are in place, but we should not have to make such an assumption.
| @@ -36,6 +36,9 @@ | |||
| <ds.connection.url>jdbc:mysql://localhost:${mysql.port}/${ds.database}?characterEncoding=UTF-8</ds.connection.url> | |||
| <ds.driver.class>com.mysql.jdbc.Driver</ds.driver.class> | |||
|
|
|||
| <mysql.dist.version>5.5.34</mysql.dist.version> | |||
| <!-- <mysql.dist.version>5.6.21</mysql.dist.version> --> | |||
There was a problem hiding this comment.
Did you purposely just modify this?
There was a problem hiding this comment.
I'm trying to test against both versions, and for the moment it's easier than switching the build params in jenkins.
There was a problem hiding this comment.
Fair enough. Ping me if anything else changes and it needs another review.
seanf
force-pushed
the
mariadb-fix
branch
3 times, most recently
from
2f87261
to
44dcd90
Compare
|
@davidmason I have modified the changeset again. It now works on 5.6.14, just trying 5.5 again now. |
|
@davidmason sorry, modified the changeset again. I just had to add another |
|
👍 |
seanf
changed the title
|
@djansen-redhat Are you taking this one over? |
|
✅ Tested. (Fedora 21, mariadb 10.0.17-1, Wildfly 8.2) |
@djansen-redhat that sounds like a problem with zanata-3.6.0-wildfly-8.1.zip, is that right? Are you saying you had duplicate mysql-connector-java packages, even before you put in the symlink? |
rhbz1048293 Fix liquibase changeset to be compatible with mysql/mariadb version > 5.5
https://bugzilla.redhat.com/show_bug.cgi?id=1048293