This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Add server logging for failure responses #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| return Response.status(Response.Status.FORBIDDEN).build(); | ||
| String msg = String.format("More than %d results.", TransUnitUtils.MAX_SIZE); | ||
| log.warn(msg); | ||
| return Response.status(Response.Status.FORBIDDEN).entity(msg) |
There was a problem hiding this comment.
Why did this line wrap, but not the one 2 lines above it? Weird.
|
Any hints on how to trigger these? |
You might be able to use a custom client which sent an invalid request (too many transunit IDs), or perhaps send an illegal document for translation, but otherwise it would require a unit test with mock objects or something like Byteman which can inject exceptions: http://byteman.jboss.org/. All of which is probably overkill for such a simple change. |
|
Agreed. |
seanf
added a commit
that referenced
this pull request
Apr 30, 2015
Add server logging for failure responses
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.