This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Make frontend module more offline friendly #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2015 12:28
…ownload them again
…n configured large value
|
|
|
Are we caching the npm modules as well? |
| @@ -17,7 +17,7 @@ | |||
| <web.target>${project.build.directory}/web</web.target> | |||
| <bundle.output>${project.build.directory}/build</bundle.output> | |||
| <bundle.dest>${bundle.output}/META-INF/resources</bundle.dest> | |||
| <node.install.directory>${project.build.directory}</node.install.directory> | |||
| <node.install.directory>${download.dir}/zanata-frontend/node-${node.version}-npm-${npm.version}</node.install.directory> | |||
There was a problem hiding this comment.
So, it should be possible for the developer to override this with -Dnode.install.directory? If so, good, but perhaps it should be documented in a readme somewhere (since it is taking a minor liberty with the dev's file system).
|
@aeng yes. The cache option is to cache npm modules. |
added 2 commits
June 9, 2015 14:16
| @@ -125,4 +129,18 @@ | |||
| </plugins> | |||
| </build> | |||
|
|
|||
| <profiles> | |||
| <profile> | |||
| <id>npm offline</id> | |||
There was a problem hiding this comment.
I would suggest npmOffline, just for consistency.
|
👍 |
|
✅ Tested, looks fine to me. |
huangp
pushed a commit
that referenced
this pull request
Jun 12, 2015
Make frontend module more offline friendly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will install node and npm into $user.home/Downloads.
It will also try to use npm cache as much as possible.