Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo #79

Closed
x3mEr opened this issue Mar 11, 2021 · 1 comment
Closed

typo #79

x3mEr opened this issue Mar 11, 2021 · 1 comment
Assignees
@SV-Zanshin
Labels
Documentation Correction/Addition

Comments

@x3mEr
Copy link

x3mEr commented Mar 11, 2021

Hello. Thanks for the great lib!

Typo in comment about bits (https://github.com/Zanduino/INA/blob/master/src/INA.cpp) in line 480:
configRegister |= convRate << 3; // shift in the BADC averages

Should be:
configRegister |= convRate << 3; // shift in the SADC averages
@SV-Zanshin SV-Zanshin self-assigned this Mar 12, 2021
SV-Zanshin pushed a commit that referenced this issue Mar 12, 2021
Documentation Fix
f5661df 
Issue #79
@SV-Zanshin
Copy link
Collaborator

Will be updated in the next release. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SV-Zanshin SV-Zanshin

Labels
Documentation Correction/Addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SV-Zanshin @x3mEr