Skip to content
This repository has been archived by the owner on Mar 11, 2018. It is now read-only.

Handle Reconnect Logic #2

Open
ZaneA opened this issue Jul 18, 2013 · 3 comments
Open

Handle Reconnect Logic #2

ZaneA opened this issue Jul 18, 2013 · 3 comments

Comments

@ZaneA
Copy link
Owner

ZaneA commented Jul 18, 2013

When an IRC connection times out, we should handle the reconnect automatically. The magic place to do this should be right here:

https://github.com/ZaneA/Idel-IRC/blob/master/js/factories.js#L177

@jsbeckr
Copy link

jsbeckr commented Jul 18, 2013

The problem is that onDisconnect won't be called by chrome.socket. Afaik there is nothing for detecting a disconnect let alone a reconnect. Maybe a PING message once in while and calling disconnect() in case the server doesn't respond will be enough?

@ZaneA
Copy link
Owner Author

ZaneA commented Jul 18, 2013

You're right, I believe around here https://github.com/ZaneA/Idel-IRC/blob/master/ports/chrome/port.js#L81 is the place where it should detect for an error code while trying to read. It would also be useful to have a TimerService or something that can be used to periodically PING the server, even better might be to have it PING after a certain amount of inactivity.

@brodock
Copy link

brodock commented May 13, 2014

With the Atom-Shell being opensourced (from github folks, see: https://github.com/atom/atom-shell), I believe that you can make this application a standalone multi-plataform with very little change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants