You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 11, 2018. It is now read-only.
The problem is that onDisconnect won't be called by chrome.socket. Afaik there is nothing for detecting a disconnect let alone a reconnect. Maybe a PING message once in while and calling disconnect() in case the server doesn't respond will be enough?
You're right, I believe around here https://github.com/ZaneA/Idel-IRC/blob/master/ports/chrome/port.js#L81 is the place where it should detect for an error code while trying to read. It would also be useful to have a TimerService or something that can be used to periodically PING the server, even better might be to have it PING after a certain amount of inactivity.
With the Atom-Shell being opensourced (from github folks, see: https://github.com/atom/atom-shell), I believe that you can make this application a standalone multi-plataform with very little change.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When an IRC connection times out, we should handle the reconnect automatically. The magic place to do this should be right here:
https://github.com/ZaneA/Idel-IRC/blob/master/js/factories.js#L177
The text was updated successfully, but these errors were encountered: