Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support User access token to create the issue #18

Closed
sshniro opened this issue Apr 21, 2020 · 2 comments
Closed

Support User access token to create the issue #18

sshniro opened this issue Apr 21, 2020 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@sshniro
Copy link
Member

sshniro commented Apr 21, 2020

Currently, the action checks for the latest bot comment to find the latest runner ID.
But users can also use their personal access token to create the issues. Due to this, the action ends of creating new issues per scan, as it cannot find a matching comment by the bot.

@thc202 thc202 added the enhancement New feature or request label Apr 21, 2020
@thc202 thc202 modified the milestones: 0.3.0, 0.4.0 Apr 21, 2020
@thc202 thc202 modified the milestones: 0.4.0, 0.5.0 Oct 8, 2020
@thc202 thc202 removed this from the 0.5.0 milestone Sep 6, 2021
@Den4200
Copy link

Den4200 commented Jun 30, 2023

Any update on this? The current behavior now is that new issues are opened on every scan, ignoring any open issues.

I found the culprit to be these two lines hardcoded to check for the GitHub Actions bot.

https://github.com/zaproxy/action-baseline/blob/ff22721137aabfd0ed356ece585fc6747f4e527c/dist/index.js#L8088

https://github.com/zaproxy/action-baseline/blob/ff22721137aabfd0ed356ece585fc6747f4e527c/dist/index.js#L8111

@thc202
Copy link
Member

thc202 commented Jun 30, 2023

Closing as duplicate of #17.

@thc202 thc202 closed this as completed Jun 30, 2023
@thc202 thc202 added bug Something isn't working duplicate This issue or pull request already exists and removed enhancement New feature or request labels Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Development

No branches or pull requests

3 participants