websocket: remove consumer on socket exception #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change WebSocketAPI to remove and unregister the event consumer on socket exceptions (e.g. channel not cleanly closed) when dispatching the events. Update changes in ZapAddOn.xml and about.html. Related to zaproxy#1489. Depends on zaproxy/zaproxy#4827 - Allow consumers to remove themselves during events
kingthorin
approved these changes
Jul 10, 2018
psiinon
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change WebSocketAPI to remove and unregister the event consumer on
socket exceptions (e.g. channel not cleanly closed) when dispatching the
events.
Update changes in ZapAddOn.xml and about.html.
Related to #1489.
Depends on zaproxy/zaproxy#4827 - Allow consumers to remove themselves
during events