Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oast: First Version #3033

Merged
merged 1 commit into from Aug 4, 2021
Merged

oast: First Version #3033

merged 1 commit into from Aug 4, 2021

Conversation

ricekot
Copy link
Member

@ricekot ricekot commented Jul 14, 2021

Classes Tree Structure Main Classes
src/main/java/org/zaproxy/addon/oast
├── ExtensionOast.java
├── OastApi.java
├── OastRequest.java
├── OastRequestHandler.java
├── OastService.java
├── services
│   ├── boast
│   │   ├── BoastEvent.java
│   │   ├── BoastOptionsPanelTab.java
│   │   ├── BoastParam.java
│   │   ├── BoastPoller.java
│   │   ├── BoastServer.java
│   │   └── BoastService.java
│   └── callback
│       ├── CallbackImplementor.java
│       ├── CallbackOptionsPanelTab.java
│       ├── CallbackParam.java
│       ├── CallbackProxyListener.java
│       └── CallbackService.java
└── ui
    ├── CustomColumn.java
    ├── DefaultCustomColumnHistoryReferencesTableModel.java
    ├── OastOptionsPanel.java
    ├── OastOptionsPanelTab.java
    ├── OastPanel.java
    ├── OastTable.java
    └── OastTableModel.java
Tests
src/test/java/org/zaproxy/addon/oast
├── OastRequestUnitTests.java
└── services
    └── boast
        ├── BoastEventUnitTests.java
        └── BoastServerUnitTests.java
Signed-off-by: ricekot

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the 2017 files really copies or should some be 2021?

List<String> addrs = NetworkUtils.getAvailableAddresses(false);
for (String addr : addrs) {
if (!addr.contains(":") && !addr.equals("localhost") && !addr.equals("127.0.0.1")) {
// Return the first IPv4 one that's not localhost
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this deal with the whole 127.0.0.0/8? Or am I over thinking?

(Yes I know this file was copied)

@ricekot ricekot force-pushed the oast/updates branch 2 times, most recently from f541713 to 063a177 Compare July 27, 2021 06:57
@ricekot ricekot force-pushed the oast/updates branch 2 times, most recently from 53c4bdc to 1e4de55 Compare August 1, 2021 13:54
@ricekot ricekot marked this pull request as ready for review August 1, 2021 13:54
@ricekot
Copy link
Member Author

ricekot commented Aug 1, 2021

This PR is ready for a review.

@ricekot
Copy link
Member Author

ricekot commented Aug 2, 2021

Thanks, tweaked.

@ricekot ricekot force-pushed the oast/updates branch 2 times, most recently from 410aa32 to fe0b5d1 Compare August 3, 2021 13:43
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: ricekot <ricekot@gmail.com>
@thc202
Copy link
Member

thc202 commented Aug 4, 2021

Thank you!

@psiinon psiinon merged commit 52030d7 into zaproxy:main Aug 4, 2021
@kingthorin
Copy link
Member

Whoop whopop!!!!! ⚡ 🚀

@ricekot ricekot deleted the oast/updates branch August 4, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants