authhelper: Add Header based session management #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
authhelper/session-headers
branch
from
1b27ebf
to
d66e02e
Compare
|
The text area needs word wrap turned on or something? |
thc202
reviewed
Jan 28, 2023
addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/ExtensionAuthhelper.java
Show resolved
Hide resolved
addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/ExtensionAuthhelper.java
Show resolved
Hide resolved
...elper/src/main/java/org/zaproxy/addon/authhelper/HeaderBasedSessionManagementMethodType.java
Outdated
Show resolved
Hide resolved
...elper/src/main/java/org/zaproxy/addon/authhelper/HeaderBasedSessionManagementMethodType.java
Outdated
Show resolved
Hide resolved
...elper/src/main/java/org/zaproxy/addon/authhelper/HeaderBasedSessionManagementMethodType.java
Outdated
Show resolved
Hide resolved
...authhelper/src/main/java/org/zaproxy/addon/authhelper/HeaderBasedSessionManagementPanel.java
Outdated
Show resolved
Hide resolved
addOns/authhelper/src/main/javahelp/org/zaproxy/addon/authhelper/resources/help/map.jhm
Outdated
Show resolved
Hide resolved
addOns/authhelper/src/main/resources/org/zaproxy/addon/authhelper/resources/Messages.properties
Outdated
Show resolved
Hide resolved
addOns/authhelper/src/main/resources/org/zaproxy/addon/authhelper/resources/Messages.properties
Outdated
Show resolved
Hide resolved
psiinon
force-pushed
the
authhelper/session-headers
branch
7 times, most recently
from
3e7fb2d
to
68de079
Compare
|
I think thats everything addressed. |
|
Actually, zaproxy/zaproxy#2620 pretty much covers it, or can.. |
psiinon
force-pushed
the
authhelper/session-headers
branch
from
68de079
to
7fa4bde
Compare
kingthorin
reviewed
Feb 2, 2023
addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/ExtensionAuthhelper.java
Outdated
Show resolved
Hide resolved
...elper/src/main/java/org/zaproxy/addon/authhelper/HeaderBasedSessionManagementMethodType.java
Outdated
Show resolved
Hide resolved
...elper/src/main/java/org/zaproxy/addon/authhelper/HeaderBasedSessionManagementMethodType.java
Outdated
Show resolved
Hide resolved
...elper/src/main/java/org/zaproxy/addon/authhelper/HeaderBasedSessionManagementMethodType.java
Outdated
Show resolved
Hide resolved
...lper/src/main/javahelp/org/zaproxy/addon/authhelper/resources/help/contents/auth-req-id.html
Show resolved
Hide resolved
...r/src/main/javahelp/org/zaproxy/addon/authhelper/resources/help/contents/session-header.html
Outdated
Show resolved
Hide resolved
...r/src/main/javahelp/org/zaproxy/addon/authhelper/resources/help/contents/session-header.html
Show resolved
Hide resolved
...r/src/main/javahelp/org/zaproxy/addon/authhelper/resources/help/contents/session-header.html
Outdated
Show resolved
Hide resolved
addOns/authhelper/src/main/resources/org/zaproxy/addon/authhelper/resources/Messages.properties
Outdated
Show resolved
Hide resolved
addOns/authhelper/src/main/resources/org/zaproxy/addon/authhelper/resources/Messages.properties
Outdated
Show resolved
Hide resolved
psiinon
force-pushed
the
authhelper/session-headers
branch
2 times, most recently
from
aabd499
to
3b22864
Compare
|
Resolved of replied to all of the comments, so ready for review again 😁 |
psiinon
force-pushed
the
authhelper/session-headers
branch
from
3b22864
to
c2a670a
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
authhelper/session-headers
branch
from
c2a670a
to
5618519
Compare
thc202
approved these changes
Feb 7, 2023
|
Thank you! |
|
@kingthorin this ok now? |
kingthorin
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI is a bit different but I think it works well in this case.
2 Rows are shown to start with an then other added when the last column is filled in.
Signed-off-by: Simon Bennetts psiinon@gmail.com