Implement a passive check for cookies without SameSite set #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Repushed with fix and unit tests |
| Pattern pattern = Pattern.compile("Set-Cookie.*" + name, Pattern.CASE_INSENSITIVE); | ||
| Matcher matcher = pattern.matcher(msg.getResponseHeader().toString()); | ||
| if (matcher.find()) { | ||
| evidence = matcher.group(); |
There was a problem hiding this comment.
Couldn't there be multiple matches at this point? So perhaps you want group(1)?
There was a problem hiding this comment.
It should just return the next match, ie the same as group(1), shouldnt it?
|
Hopefully fixed all of those comments |
|
Looks good to me. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes zaproxy/zaproxy#2716 Implement a passive check for cookies without SameSite set