postman: Implement request deserialization #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitikaSoni
force-pushed
the
req-des
branch
2 times, most recently
from
2de0c41
to
17d9c1a
Compare
thc202
reviewed
Aug 1, 2023
kingthorin
reviewed
Aug 2, 2023
addOns/postman/src/main/java/org/zaproxy/addon/postman/models/Request.java
Outdated
Show resolved
Hide resolved
addOns/postman/src/main/java/org/zaproxy/addon/postman/models/Request.java
Outdated
Show resolved
Hide resolved
VitikaSoni
force-pushed
the
req-des
branch
2 times, most recently
from
4c29274
to
6270f8a
Compare
|
This is ready 🙂 |
thc202
reviewed
Aug 11, 2023
addOns/postman/src/main/java/org/zaproxy/addon/postman/models/Body.java
Outdated
Show resolved
Hide resolved
addOns/postman/src/main/java/org/zaproxy/addon/postman/models/Body.java
Outdated
Show resolved
Hide resolved
addOns/postman/src/main/java/org/zaproxy/addon/postman/models/Body.java
Outdated
Show resolved
Hide resolved
addOns/postman/src/main/java/org/zaproxy/addon/postman/models/Body.java
Outdated
Show resolved
Hide resolved
addOns/postman/src/main/java/org/zaproxy/addon/postman/models/Request.java
Outdated
Show resolved
Hide resolved
VitikaSoni
force-pushed
the
req-des
branch
2 times, most recently
from
51f06e8
to
ae1db91
Compare
|
Done 🙂 |
- Renamed AbstractItemDeserializer to ListDeserializer and made it usable for subclasses of the newly created AbstractListElement class - Created a new ObjectDeserializer to ignore an object when its signature doesn't match, rather than throwing an exception - Created the necessary model classes to deserialize the request - Upgraded the Jackson version Signed-off-by: VitikaSoni <vitika.program@gmail.com>
thc202
approved these changes
Aug 15, 2023
|
Thank you! |
|
You will have to push again, some of the checks are stuck. |
kingthorin
approved these changes
Aug 15, 2023
|
Did they pass in the meantime? |
|
Yes it was all green when I got here 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
AbstractItemDeserializertoListDeserializerand made it usable for subclasses of the newly createdAbstractListElementclassObjectDeserializerto ignore an object when its signature doesn't match, rather than throwing an exceptionRelated Issues
zaproxy/zaproxy#6960
Checklist
./gradlew spotlessApplyfor code formatting