Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstart: Update Tech Detection terminology #5539

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Jun 27, 2024

@thc202 thc202 changed the title Update Tech Detection terminology quickstart: Update Tech Detection terminology Jun 27, 2024
@@ -58,8 +58,8 @@ quickstart.cmdline.zapit.root.inputs = \tNumber of HTML input fields: {0}
quickstart.cmdline.zapit.root.links = \tNumber of HTML links: {0}
quickstart.cmdline.zapit.start = ZAPit scan of {0}
quickstart.cmdline.zapit.tech = Technology:
quickstart.cmdline.zapit.tech.disabled = Technology: Not available (enable the wappalyzer add-on)
Copy link
Member

@thc202 thc202 Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be the ID of the add-on not the name (fine changing it anyway).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured users would see the name more often than the id.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will need the ID to install from the command line though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better if I made it "Technology Detection (wappalyzer)" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better would be "Technology Detection (techdetect)" or something like that :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we weren't in a position to change the ID(s)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not yet.

@thc202
Copy link
Member

thc202 commented Jun 27, 2024

Thank you!

@kingthorin kingthorin merged commit 5803df8 into zaproxy:main Jun 27, 2024
10 checks passed
@kingthorin kingthorin deleted the qs-wapp-td branch June 27, 2024 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants