grpc: skip non-gRPC responses in the variant #5548
Merged
+111
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amitpanwar789 can you check? |
Looks good |
psiinon
approved these changes
Jul 1, 2024
kingthorin
previously approved these changes
Jul 1, 2024
kingthorin
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Should probably have some tests 😃
kingthorin
dismissed
their stale review
Dismissing approval review, pending addition of tests 😉
Check that the response is valid gRPC before trying to decode it, otherwise it would lead to unnecessary warns as the response is not gRPC. Signed-off-by: thc202 <thc202@gmail.com>
thc202
force-pushed
the
grpc/variant/skip-no-grpc-resp
branch
from
4c1d5cb
to
2f200b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the response is valid gRPC before trying to decode it, otherwise it would lead to unnecessary warns as the response is not gRPC.