Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https upgrade bug on startup #162

Closed
dscrobonia opened this issue Jul 24, 2018 · 1 comment
Closed

https upgrade bug on startup #162

dscrobonia opened this issue Jul 24, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@dscrobonia
Copy link
Contributor

dscrobonia commented Jul 24, 2018

Everytime i restart the HUD the https upgrade has a bug on the first load. I have to refresh the tab to have it work. The sharedData.upgradedDomains doesn't include the target page. This means that scope, alerts, history, and any other tool taht depends on the correct protocol for the api won't work

I believe this is because the domain is only added when ZAP sends the event via websockets. But on the first load the event is sent before the HUD can receive it (?). Probably should wrap this into a more robust startup, which I should focus on in #160 . This may require a more thorough description of how startup works.

@psiinon

@dscrobonia dscrobonia changed the title https upgrade fails on startup https upgrade bug on startup Jul 24, 2018
@thc202
Copy link
Member

thc202 commented Jul 24, 2018

I'm seeing this issue (frequently) too, e.g.:

ERROR errorHandler: TypeError: sharedData.upgradedDomains is undefined
     @https:    https://zap//zapCallBackUrl/-6949015154753721973?name=tools/commonAlerts.js 95:: {}

Interestingly only the right alert tools are broken, when clicked it throws:

ERROR errorHandler: [object ErrorEvent]: {"isTrusted":true} -6949015154753721973:631:3
     TypeError: sharedData.upgradedDomains is undefined

the left alert tools show the dialogue when clicked.

For me reloading the tab does not fix it, have to restart the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants