Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmodplug: MixSoundBuffer size mismatch #48

Closed
arthurzam opened this issue Jul 17, 2016 · 2 comments
Closed

libmodplug: MixSoundBuffer size mismatch #48

arthurzam opened this issue Jul 17, 2016 · 2 comments

Comments

@arthurzam
Copy link
Contributor

When compiling QMPlay2 with -flto flag (I really recommend using it when building the release builds), a warning is found:

/home/arthur/dev/QMPlay2/src/modules/Modplug/libmodplug/snd_dsp.cpp:102:12: warning: type of 'MixSoundBuffer' does not match original declaration
 extern int MixSoundBuffer[MIXBUFFERSIZE*2];
            ^
/home/arthur/dev/QMPlay2/src/modules/Modplug/libmodplug/fastmix.cpp:17:5: note: previously declared here
 int MixSoundBuffer[MIXBUFFERSIZE*4];
     ^

I guess this snippet explains the problem - mismatch in size of array. I guess the best solution would be change the size to MIXBUFFERSIZE*4 in snd_dsp.cpp:102, but because I don't know what happens in libmodplug I think this is better for you to review it.

@zaps166
Copy link
Owner

zaps166 commented Jul 17, 2016

I guess (...)

Does it link properly if extern also have MIXBUFFERSIZE*4 ?

@zaps166
Copy link
Owner

zaps166 commented Jul 17, 2016

Aaah, this is only a warning... 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants