Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--help, help, and lab/git are all inconsistent #107

Closed
nesl247 opened this issue Feb 1, 2018 · 4 comments
Closed

--help, help, and lab/git are all inconsistent #107

nesl247 opened this issue Feb 1, 2018 · 4 comments
Labels
Projects
Milestone

Comments

@nesl247
Copy link

nesl247 commented Feb 1, 2018

After aliasing git to lab, I noticed there are several inconsistencies to the help dialog. git --help, git help and git all return different output. git --help returns the output of lab --help, git help returns the output of hub --help and git returns the output of lab which is a combination of hub + lab.

All of these should be returning the same output. If hub isn't installed, lab and lab --help should both be returning the decorated git --help output. If it is installed, it should be decorating the hub --help output.

@zaquestion
Copy link
Owner

Thanks for reporting, will get a fix up for this today or tomorrow. I'm definitely guilting of missing some edge cases that fall outside my workflow so I really appreciate the report

@zaquestion zaquestion added the bug label Feb 2, 2018
@zaquestion zaquestion added this to the 0.9.5 milestone Feb 2, 2018
@zaquestion zaquestion added this to To Do in Bugs via automation Feb 2, 2018
@zaquestion
Copy link
Owner

This is a little trickier than I thought it would be. It requires hacking around cobras built in help functionality. I managed to get the help output consistent and in the process broke all of lab's help functionality. I'll need to put in some extra logic to properly execute the wrapped help when appropriate and keep lab's help intact.

zaquestion added a commit that referenced this issue Feb 8, 2018
lab should be wrapping git help functionality and only showing its on when appropriate. The bulk of these changes address the challenges in doing so
@zaquestion
Copy link
Owner

I think the above #108 addresses all of the issues here. It deserves some thorough tests and review given the borderline hacks required to make this work with cobra. Should be able to get tests in place this weekend and planning to upgrade cobra to see if anything in a newer version that can be put to use.

zaquestion added a commit that referenced this issue Feb 9, 2018
lab should be wrapping git help functionality and only showing its on when appropriate. The bulk of these changes address the challenges in doing so
zaquestion added a commit that referenced this issue Feb 17, 2018
lab should be wrapping git help functionality and only showing its on when appropriate. The bulk of these changes address the challenges in doing so
zaquestion added a commit that referenced this issue Feb 17, 2018
[#107] (bug) align lab help functionality with git help and --help
@zaquestion
Copy link
Owner

Fixed in #108 will go out in 0.9.5

Bugs automation moved this from To Do to Done Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Bugs
  
Done
Development

No branches or pull requests

2 participants