New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2 #220
Drop Python 2 #220
Conversation
FWIW I'm ok skipping the macOS bit and saving that for another PR. Maybe mark it as a known failure though? |
Sounds good! I've skipped the OSX build in this PR and have switched to using GitHub Actions over in #221 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, so cathartic!
One small thought, there is still a Buffer
class in numcodecs/compat_ext.pyx. That class was originally created to work around some buffer support differences between PY2 and PY3, although we must've removed some of that compatibility code a while back as no longer needed after we did some work upstream in the ensure_contiguous_array()
function. In any case, it's probably worth keeping the Buffer
class because it provides some convenience. However, the docstring for the class is a bit out of date now, probably worth fixing to clarify that it's just a convenience class, nothing to do with compatibility.
Thanks for reviewing @alimanfoo! I've updated the docstring for |
Co-Authored-By: Alistair Miles <alimanfoo@googlemail.com>
Thanks James for the PR and Alistair for the review! 😄 |
Looks like readthedocs is going to need updating to use python 3 as well: https://readthedocs.org/projects/numcodecs/builds/11416597/ Edit: fixed in https://readthedocs.org/projects/numcodecs/builds/11743058/ by changing the interpreter. |
Thanks Josh 😄 |
Closes #219
TODO:
tox -e py38
passes locallytox -e py27
passes locallyDocstrings and API docs for any new/modified user-facing classes and functionstox -e docs
passes locally