Skip to content

Conversation

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Mar 28, 2020

Closes #219

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py38 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@jakirkham
Copy link
Member

jakirkham commented Mar 28, 2020

FWIW I'm ok skipping the macOS bit and saving that for another PR. Maybe mark it as a known failure though?

@jrbourbeau
Copy link
Member Author

Sounds good! I've skipped the OSX build in this PR and have switched to using GitHub Actions over in #221

Copy link
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, so cathartic!

One small thought, there is still a Buffer class in numcodecs/compat_ext.pyx. That class was originally created to work around some buffer support differences between PY2 and PY3, although we must've removed some of that compatibility code a while back as no longer needed after we did some work upstream in the ensure_contiguous_array() function. In any case, it's probably worth keeping the Buffer class because it provides some convenience. However, the docstring for the class is a bit out of date now, probably worth fixing to clarify that it's just a convenience class, nothing to do with compatibility.

@jrbourbeau
Copy link
Member Author

Thanks for reviewing @alimanfoo! I've updated the docstring for Buffer to indicate it's just a convenience class and also removed some lingering Python 2 references in documentation and our tox setup

Co-Authored-By: Alistair Miles <alimanfoo@googlemail.com>
@jakirkham jakirkham merged commit 1734bee into zarr-developers:master Apr 1, 2020
@jakirkham
Copy link
Member

Thanks James for the PR and Alistair for the review! 😄

@joshmoore
Copy link
Member

joshmoore commented Aug 26, 2020

Looks like readthedocs is going to need updating to use python 3 as well: https://readthedocs.org/projects/numcodecs/builds/11416597/

Edit: fixed in https://readthedocs.org/projects/numcodecs/builds/11743058/ by changing the interpreter.

@jakirkham
Copy link
Member

Thanks Josh 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 2 support

4 participants