Skip to content

Move OSX CI builds to GitHub Actions #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrbourbeau merged 1 commit into from
Mar 30, 2020
Merged

Move OSX CI builds to GitHub Actions #221

jrbourbeau merged 1 commit into from
Mar 30, 2020

Conversation

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Mar 28, 2020 •
edited
Loading

This PR moves our OSX CI builds over to GitHub Actions.

cc @jakirkham

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py38 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@jrbourbeau jrbourbeau mentioned this pull request Mar 28, 2020
Merged
8 tasks
@jrbourbeau
Copy link
Member Author

jrbourbeau commented Mar 28, 2020

Status checks for GitHub Actions won't appear on pull requests until this PR is merged into master, but you can see the OSX builds for this PR here https://github.com/jrbourbeau/numcodecs/actions?query=branch%3Agha-osx

alimanfoo
alimanfoo approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrbourbeau jrbourbeau merged commit 188cb2d into zarr-developers:master Mar 30, 2020
@jrbourbeau jrbourbeau deleted the gha-osx branch March 30, 2020 18:08
@jrbourbeau
Copy link
Member Author

jrbourbeau commented Mar 30, 2020

Thanks for reviewing @alimanfoo : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alimanfoo alimanfoo alimanfoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrbourbeau @alimanfoo