Fix is_total_slice for size-1 dimensions
#1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes zarr-developers#1730 Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
dcherian
force-pushed
the
fix-is-total-slice
branch
from
aa0c7b1
to
88ba0cd
Compare
jhamman
approved these changes
Apr 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 38 38
Lines 14640 14644 +4
=======================================
+ Hits 14638 14642 +4
Misses 2 2
|
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
May 13, 2024
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
May 16, 2024
)" This reverts commit 9d046ea.
4 tasks
jhamman
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1730
[Description of PR]
TODO: