Fix a regression with scalar indexing due to #1800 #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 38 38
Lines 14667 14695 +28
=======================================
+ Hits 14665 14693 +28
Misses 2 2
|
dcherian
commented
May 16, 2024
| @@ -52,6 +52,8 @@ def is_scalar(value, dtype): | |||
| return True | |||
| if isinstance(value, tuple) and dtype.names and len(value) == len(dtype.names): | |||
| return True | |||
| if dtype.kind == "O" and not isinstance(value, np.ndarray): | |||
There was a problem hiding this comment.
This is the core issue in #1874. We need to treat [1, 'C'] as a scalar for object arrays.
Is this the right condition?
jhamman
approved these changes
May 16, 2024
|
@zarr-developers/python-core-devs - I'm planning to merge this and make a 2.18.1 release later today. |
4 tasks
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in indexing out scalars from size-1 chunks.
TODO: