Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd to old V3 supported codecs #1914

Merged
merged 3 commits into from
May 26, 2024

Conversation

rabernat
Copy link
Contributor

@rabernat rabernat commented May 26, 2024

This adds zstd to the list of codecs supported by the old V3 code path. This is essentially a backport to support existing data that was already written this way.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@rabernat rabernat requested a review from jhamman May 26, 2024 17:55
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (bf89533) to head (07aab24).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1914   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files          38       38           
  Lines       14695    14703    +8     
=======================================
+ Hits        14693    14701    +8     
  Misses          2        2           
Files Coverage Δ
zarr/codecs.py 100.00% <100.00%> (ø)
zarr/meta.py 100.00% <100.00%> (ø)
zarr/tests/test_meta.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Comment on lines +271 to +272
@pytest.mark.parametrize("cname", ["zlib", "zstd"])
def test_encode_decode_array_dtype_shape_v3(cname):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for review: I made this change to get test coverage to 100%.

Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rabernat! We can make a patch release with this in it.

@jhamman jhamman merged commit 3e98c3b into zarr-developers:main May 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants