Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging is done on root level, making it impossible to silence without also silencing out from from app #1496

Closed
dreusel opened this issue Aug 27, 2023 · 0 comments · Fixed by #1497
Milestone

Comments

@dreusel
Copy link
Contributor

dreusel commented Aug 27, 2023

Description

First off I want to say this library is awesome.
I encountered this library when using one of your other projects (odrive-gui), which is also awesome. I want to propose some small fixes and extras to it, however development is a bit hard because the console output gets flooded with these messages:

WARNING:root:binding propagation for 42 active links took 0.034 s

Firs, using the root binding makes it hard to understand where they are coming from. I had to search this github repo (had a hunch it might be from this library) to find it. But also from my (current) point of view these messages are irrelevant but they do make it very hard so see the log messages generated by the application itself. The only way to stop the flooding is to set the log level to ERROR, but I do want to be able to use DEBUG level logs in my own application.

@rodja rodja linked a pull request Aug 27, 2023 that will close this issue
@falkoschindler falkoschindler added this to the 1.3.13 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants