Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggest]: Support work with windows. #1

Closed
nonzzz opened this issue Jul 27, 2022 · 2 comments
Closed

[Suggest]: Support work with windows. #1

nonzzz opened this issue Jul 27, 2022 · 2 comments
Labels
feature

Comments

@nonzzz
Copy link

nonzzz commented Jul 27, 2022

Background

From K/pkg/basedir.go. I think we can use os.Getenv replace user.Current(). Because os.GetEnv can get clean infomation. And we only judge user platform that is 'win' or others.
@zaunist
Copy link
Owner

zaunist commented Jul 27, 2022

Thanks for your suggestion. We will update in subsequent iterations.

@nonzzz
Copy link
Author

nonzzz commented Jul 28, 2022

I already saw you're refactor the part. I will close this issue.

@nonzzz nonzzz closed this as completed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zaunist @nonzzz