Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to just build iD3 tags for use in other applications #5

Closed
cjus opened this issue Oct 27, 2016 · 2 comments
Closed

Ability to just build iD3 tags for use in other applications #5

cjus opened this issue Oct 27, 2016 · 2 comments

Comments

@cjus
Copy link

cjus commented Oct 27, 2016

I have a need to build iD3 tags but not for file storage. Rather I need to send the tag data to an encoding service.

I refactored the code a bit to extract the iD3 creation code from the write method. I'd like to submit a pull request but wanted to check with you guys first. ;-)

https://github.com/cjus/node-id3/blob/id3-buffer-create/index.js

@Zazama
Copy link
Owner

Zazama commented Nov 11, 2016

Hi,

sorry for the late answer.
Your code would be a nice addition to the functionality and also doesn't change the existing calls.

@Zazama
Copy link
Owner

Zazama commented Oct 11, 2017

Added in 49f649b

//  Create a ID3-Frame buffer from passed tags
//  Synchronous
let ID3FrameBuffer = NodeID3.create(tags)   //  Returns ID3-Frame buffer
//  Asynchronous
NodeID3.create(tags, function(frame) {  })

@Zazama Zazama closed this as completed Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants