Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ZC-specific uses of secp256k1 are strict (and disallow malleability). #149

Closed
nathan-at-least opened this issue Apr 1, 2015 · 1 comment
Closed

Ensure ZC-specific uses of secp256k1 are strict (and disallow malleability). #149

nathan-at-least opened this issue Apr 1, 2015 · 1 comment
Labels
A-crypto Area: Cryptography I-SECURITY Problems and improvements related to security.

Comments

@nathan-at-least
Copy link
Contributor

It may be that ZC-specific code uses Bitcoin signature/verification for Pour non-malleability, in which case we need to lock down looseness in verification acceptance along the same lines as upstream non-malleability changes.

(This is currently, merely a suspected issue on Nathan's part, and he needs to review the code to determine how it maps to H_sig, H_1, and H_2 in the paper.)
@nathan-at-least nathan-at-least added I-SECURITY Problems and improvements related to security. A-crypto Area: Cryptography labels Apr 1, 2015
@nathan-at-least nathan-at-least self-assigned this Apr 1, 2015
@nathan-at-least nathan-at-least removed their assignment Oct 6, 2015
ebfull pushed a commit that referenced this issue Nov 4, 2015
@sipa
Squashed 'src/secp256k1/' changes from b0210a9..bccaf86
ecae2ac 
bccaf86 Merge pull request #150
2a53a47 Merge pull request #151
5f5a31f Merge pull request #149
3907277 Merge pull request #142
a3e0611 Enable tests in x86 travis builds
45da235 x86 builder
8bb0e93 Merge pull request #155
971fe81 build: fix openssl detection for cross builds
f22d73e Explicitly access %0..%2 as 64-bit so we use the right registers for x32 ABI
e66d4d6 Avoid the stack in assembly and use explicit registers
cf7b2b4 Fix ECDSA message hashes to 32 bytes
056ad31 Really compile with -O3 by default
74ad63a Merge pull request #146
9000458 Merge pull request #145
1f46b00 build: fix __builtin_expect detection for clang
aaba2e0 Merge pull request #136
8a0775c Merge pull request #144
ee1eaa7 Merge pull request #141
c88e2b8 Compile with -O3 by default
6558a26 Make the benchmarks print out stats
000bdf6 Rename bench_verify to bench_recovery
7c6fed2 Add a few more additional tests.
992e03b travis: add clang to the test matrix
b43b79a Merge pull request #143
e06a924 Include time.h header for time().
8d11164 Add some additional tests.
3545627 Merge pull request #118
6a9901e Merge pull request #137
376b28b Merge pull request #128
1728806 Merge pull request #138
a5759c5 Check return value of malloc
39bd94d Variable time normalize
ad86bdf Merge pull request #140
54b768c Another redundant secp256k1_fe_normalize
69dcaab Merge pull request #139
1c29f2e Remove redundant secp256k1_fe_normalize from secp256k1_gej_add_ge_var.
2b9388b Remove unused secp256k1_fe_inv_all
f461b76 Allocate precomputation arrays on the heap
b2c9681 Make {mul,sqr}_inner use the same argument order as {mul,sqr}
6793505 Convert YASM code into inline assembly
f048615 Rewrite field assembly to match the C version
3ce74b1 Tweak precomputed table size for G

git-subtree-dir: src/secp256k1
git-subtree-split: bccaf86caa9c44166e5a66600b742c516e03c3f0
@daira daira added this to the Feb 15 milestone Feb 3, 2016
@daira
Copy link
Contributor

daira commented Sep 30, 2016

We do not use ECDSA for JoinSplit nonmalleability. We use Ed25519 (see #977), and have taken into account malleability issues for that algorithm -- in particular, we enforce that S is in range.

@daira daira closed this as completed Sep 30, 2016
@daira daira removed this from the Feb 15 milestone Sep 30, 2016
forafish pushed a commit to BitsumIO/sumcoin that referenced this issue Oct 30, 2018
@Asherda
Merge pull request zcash#149 from VerusCoin/dev
672d319 
Dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-crypto Area: Cryptography I-SECURITY Problems and improvements related to security.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daira @nathan-at-least