Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focused audit of libsnark verifier. #743

Closed
nathan-at-least opened this issue Mar 2, 2016 · 1 comment · Fixed by #4060
Closed

Focused audit of libsnark verifier. #743

nathan-at-least opened this issue Mar 2, 2016 · 1 comment · Fixed by #4060
Labels
I-SECURITY Problems and improvements related to security. libzcash Z-libsnark Historic: libsnark

Comments

@nathan-at-least
Copy link
Contributor

The verifier is a higher priority for security audit, since that defines consensus and is the easiest component for remote parties to supply malicious input to.
@nathan-at-least nathan-at-least added I-SECURITY Problems and improvements related to security. Z-libsnark Historic: libsnark libzcash labels Mar 2, 2016
@zookozcash
Copy link

Ian Miers, who is (among other things) one of the original authors of that code, just told me: “It takes untrusted binary input, deserializes it into this academic code, and if we didn't accidentally put a buffer overflow in there I will be impressed.”

@daira daira mentioned this issue Jun 26, 2019
Merged
zkbot added a commit that referenced this issue Aug 12, 2019
@zkbot
Auto merge of #4060 - str4d:remove-libsnark, r=<try>
358a89c 
Remove libsnark

To-do:

- [x] Fix RPC tests.
- [ ] Remove now-dead codepaths.
- [ ] Add notable changes.

Closes #743. Closes #750. Closes #894. Closes #903.
Closes #1125. Closes #1136. Closes #1240. Closes #1264.
Closes #1516. Closes #1517. Closes #1651. Closes #2064.
Closes #2158. Closes #3478. Closes #3652. Closes #3744.
zkbot added a commit that referenced this issue Aug 22, 2019
@zkbot
Auto merge of #4060 - str4d:remove-libsnark, r=<try>
55ced22 
Remove libsnark

To-do:

- [x] Fix RPC tests.
- [ ] Remove now-dead codepaths.
- [ ] Add notable changes.

Closes #521.
Closes #743. Closes #750. Closes #894. Closes #903.
Closes #1125. Closes #1136. Closes #1240. Closes #1264.
Closes #1516. Closes #1517. Closes #1651. Closes #2064.
Closes #2158. Closes #3478. Closes #3652. Closes #3744.
@zkbot zkbot closed this as completed in 961c0d5 Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-SECURITY Problems and improvements related to security. libzcash Z-libsnark Historic: libsnark
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove libsnark str4d/zcash
2 participants
@nathan-at-least @zookozcash