Equihash: Pass each obtained solution to a callback for immediate checking #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
added this to the z8 release - core (excl. RPC) audit freeze, functional PoW milestone
str4d
added
A-pow
|
ACK. |
str4d
removed
the
S-waiting-on-review
|
@zkbot r+ |
|
📌 Commit 51eb527 has been approved by |
|
⌛ Testing commit 51eb527 with merge 55f232b... |
|
Buildbot is hanging on RPC tests because of a bug in this commit. |
| } | ||
| return CheckProofOfWork(pblock->GetHash(), pblock->nBits, Params().GetConsensus()); | ||
| }; | ||
| if (EhBasicSolveUncancellable(n, k, curr_state, validBlock)); |
There was a problem hiding this comment.
Can you spot the problem with this line? 🔎
This is a good example of an easily-overlooked change that can subtly change the execution logic. Or not-so-subtly in this case, thanks to the tests!
zkbot
pushed a commit
that referenced
this pull request
Jul 30, 2016
Equihash: Pass each obtained solution to a callback for immediate checking Closes #1143
|
Yes, let's make brackets a requirement on all code. I wish we could lint it. |
|
☀️ Test successful - zcash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1143