Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sapling benchmarks to benchmark runner #3843

Merged
merged 1 commit into from Feb 19, 2019

Conversation

6 participants
@str4d
Copy link
Contributor

commented Feb 16, 2019

Follow-up to #3611. Once this is merged, we can add the Sapling benchmarks to CI.

@str4d str4d added the benchmarking label Feb 16, 2019

@str4d str4d added this to the v2.0.4 milestone Feb 16, 2019

@str4d str4d requested review from charlieok and bitcartel Feb 16, 2019

@tromer

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

Confirmed, these now work for me:
./qa/zcash/performance-measurements.sh time createsaplingspend
./qa/zcash/performance-measurements.sh time createsaplingoutput
./qa/zcash/performance-measurements.sh time verifysaplingspend
./qa/zcash/performance-measurements.sh time verifysaplingoutput

@daira

daira approved these changes Feb 17, 2019

Copy link
Contributor

left a comment

utACK.

@daira daira added this to Needs Prioritization in Arborist Team via automation Feb 17, 2019

@charlieok
Copy link
Contributor

left a comment

I successfully ran the above four commands just now on a fresh install/build on Debian 9.

Tested ACK.

@mdr0id

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 18, 2019

📌 Commit ecde950 has been approved by mdr0id

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 18, 2019

⌛️ Testing commit ecde950 with merge 87171d3...

zkbot added a commit that referenced this pull request Feb 18, 2019

Auto merge of #3843 - str4d:sapling-bench-runner, r=mdr0id
Add Sapling benchmarks to benchmark runner

Follow-up to #3611. Once this is merged, we can add the Sapling benchmarks to CI.
@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2019

☀️ Test successful - pr-merge
Approved by: mdr0id
Pushing 87171d3 to master...

@zkbot zkbot merged commit ecde950 into zcash:master Feb 19, 2019

1 check passed

homu Test successful
Details

Arborist Team automation moved this from Needs Prioritization to Released (Merged in Master) Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.