Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sapling benchmarks to benchmark runner #3843

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Feb 16, 2019

Follow-up to #3611. Once this is merged, we can add the Sapling benchmarks to CI.

@str4d str4d added the A-benchmarks Area: Benchmarks label Feb 16, 2019
@str4d str4d added this to the v2.0.4 milestone Feb 16, 2019
@tromer
Copy link
Contributor

tromer commented Feb 16, 2019

Confirmed, these now work for me:
./qa/zcash/performance-measurements.sh time createsaplingspend
./qa/zcash/performance-measurements.sh time createsaplingoutput
./qa/zcash/performance-measurements.sh time verifysaplingspend
./qa/zcash/performance-measurements.sh time verifysaplingoutput

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

Copy link
Contributor

@charlieok charlieok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully ran the above four commands just now on a fresh install/build on Debian 9.

Tested ACK.

@mdr0id
Copy link
Contributor

mdr0id commented Feb 18, 2019

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Feb 18, 2019

📌 Commit ecde950 has been approved by mdr0id

@zkbot
Copy link
Contributor

zkbot commented Feb 18, 2019

⌛ Testing commit ecde950 with merge 87171d3...

zkbot added a commit that referenced this pull request Feb 18, 2019
Add Sapling benchmarks to benchmark runner

Follow-up to #3611. Once this is merged, we can add the Sapling benchmarks to CI.
@zkbot
Copy link
Contributor

zkbot commented Feb 19, 2019

☀️ Test successful - pr-merge
Approved by: mdr0id
Pushing 87171d3 to master...

@zkbot zkbot merged commit ecde950 into zcash:master Feb 19, 2019
@str4d str4d deleted the sapling-bench-runner branch March 10, 2020 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmarks Area: Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants