Bitcoin 0.12 cleanup PRs 2 #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `generate` RPC has no default `numblocks` and a numeric value is required.
* Introduce new constant MIN_CHANGE and use it instead of the hardcoded "CENT" * Add test case for MIN_CHANGE * Introduce new constant for -mintxfee default: DEFAULT_TRANSACTION_MINFEE = 1000
Zcash: Only includes non-QT parts
* Don't allow off-by-one or more * Make clear dust is coupled with minRelayTxFee * Check rounding for odd values
str4d
added
C-upstream-port
|
This PR only requires one review, as it's all general changes that don't affect consensus or risk user funds. |
ebfull
approved these changes
Dec 18, 2019
|
@zkbot r+ |
|
📌 Commit 136e1c0 has been approved by |
|
⌛ Testing commit 136e1c0 with merge 8713d73daf5bc13f633986ef08d8920d4a64cbb9... |
|
💔 Test failed - pr-merge |
|
@zkbot retry |
|
⌛ Testing commit 136e1c0 with merge 2da77edbfed83c8add78e4cefe172d2e4fea066c... |
|
The retry will fail, because the test failed due to the "absurdly high fee" bound being altered (and changing the error message). When the retry fails, I'll push the fix and re-r+. |
|
💔 Test failed - pr-merge |
|
Fix pushed. @zkbot r+ |
|
📌 Commit f93db12 has been approved by |
zkbot
added a commit
that referenced
this pull request
Dec 18, 2019
Bitcoin 0.12 cleanup PRs 2 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6631 - bitcoin/bitcoin#6664 - Only the first commit (we already had the second through bitcoin/bitcoin#6825). - bitcoin/bitcoin#6669 - bitcoin/bitcoin#6887 - Only the non-QT parts. - bitcoin/bitcoin#6962 - bitcoin/bitcoin#6822 - Only first and third commits (we already had the second through an earlier PR). - bitcoin/bitcoin#7136 - Excludes Travis CI changes, and fixes to documents we don't have anymore. - bitcoin/bitcoin#7084 - bitcoin/bitcoin#7509 - bitcoin/bitcoin#7617 - bitcoin/bitcoin#7726 Part of #2074.
This was referenced Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from the following upstream PRs:
Part of #2074.