Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZIP 304] Sapling Address Signatures #376

Closed
wants to merge 0 commits into from
Closed

[ZIP 304] Sapling Address Signatures #376

wants to merge 0 commits into from

Conversation

str4d
Copy link
Collaborator

@str4d str4d commented Jun 1, 2020

Closes #345.

@str4d str4d added the S-scratching-an-itch Status: Something we haven't planned for a sprint but are doing anyway label Jun 1, 2020
@str4d str4d mentioned this pull request Jun 1, 2020
Open
@str4d str4d requested review from daira, dconnolly and ebfull June 1, 2020 05:14
@daira
Copy link
Collaborator

daira commented Jun 1, 2020

Concept ACK. Will do a more thorough review when I get back from vacation.

daira
daira reviewed Jun 1, 2020
View reviewed changes
zip-0304.rst Outdated Show resolved Hide resolved
@r3ld3v r3ld3v added this to the Core Sprint 2020-21 milestone Jun 1, 2020
@str4d str4d removed this from the Core Sprint 2020-21 milestone Jun 3, 2020
daira
daira approved these changes Jul 18, 2020
View reviewed changes
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@daira daira closed this Jul 18, 2020
@daira daira mentioned this pull request Sep 14, 2020
Closed
@str4d str4d deleted the zip-304 branch December 14, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@dconnolly dconnolly Awaiting requested review from dconnolly

@ebfull ebfull Awaiting requested review from ebfull

Assignees
No one assigned
Labels
S-scratching-an-itch Status: Something we haven't planned for a sprint but are doing anyway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ZIP 304] Sapling Address Signatures (signmessage/verifymessage support)
3 participants
@str4d @daira @r3ld3v