Assign attributes directly during import validation #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g UTC time into local datetime
| * Thibaud Guillaume-Gentil | ||
| * Mark Van Holstyn | ||
| * Victor Costan | ||
| Tioeuaeuesting webhook to Jenkins |
There was a problem hiding this comment.
I don't think you meant to commit this?
|
@trandoanhung1991 If you remove your change to README.markdown and squash this into a single commit that would probably help move this along. I think there's been another issue discovered that this fix could resolve. See #235. I would also suggest referencing the related issue #140 that you opened in the description. 😄 |
|
For some reason I can't find this repo anywhere. I'll close this PR and create a new one, is that ok? |
|
Just in case, the new PR is #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent parsing UTC time into local datetime