Update the installer! #43
Conversation
pschmitt
changed the title
pschmitt
force-pushed
the
update-default-install-dir
branch
from
1f86c57
to
8de591b
Compare
doc/install.sh
Outdated
| # Get the download-progress bar tool | ||
| GIT_PROCESS_SCRIPT_URL="https://raw.githubusercontent.com/zdharma-continuum/zinit/${ZINIT_BRANCH}/git-process-output.zsh" | ||
| mkdir -p /tmp/zinit | ||
| cd /tmp/zinit || { echo "Failed to cd to /tmp/zinit" >&2; exit 1; } |
There was a problem hiding this comment.
If you're messing with temp directories, how about fixing the security issues?
Use TMPDIR if available with a fallback to /tmp/zinit-$UID/ and ensure you properly chmod/chown or exit if it already exists.
There was a problem hiding this comment.
Makes sense to do so but a bit out of scope for this MR. Will do.
| echo "[34m▓▒░[0m .zshrc already contains \`zinit …' commands – not making changes." | ||
| RCUPDATE=0 | ||
| fi | ||
|
|
||
| if [ $RCUPDATE -eq 1 ]; then | ||
| echo "[34m▓▒░[0m Updating $THE_ZDOTDIR/.zshrc (10 lines of code, at the bottom)" | ||
| ZINIT_HOME="$(echo $ZINIT_HOME | sed "s|$HOME|\$HOME|")" | ||
| ZINIT_HOME="$(echo "$ZINIT_HOME" | sed "s|$HOME|\$HOME|")" |
There was a problem hiding this comment.
This can be done entirely in Zsh
There was a problem hiding this comment.
Yeah the entire script could in zsh. What's your point?
There was a problem hiding this comment.
Ah, I missed that it was in /bin/sh. My bad.
That actually bothered me as well. Didn't want to create a "I REWROTE THE ENTIRE INSTALLER PLZ REVIEW" MR though :D I'll create an issue to refactor and over-engineer the install script. |
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ZINIT_BRANCH(defaults to master) This might be useful for development, CI and when (if!) we decide to update change the main branch of zinit to "main".