Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overengineer the installer #61

Merged
merged 28 commits into from
Nov 17, 2021
Merged

Overengineer the installer #61

merged 28 commits into from
Nov 17, 2021

Conversation

pschmitt
Copy link
Member

@pschmitt pschmitt commented Nov 14, 2021 •
edited

Fixes #60 and #45

TODO:

  • more emojis
  • warn about zsh version if below 5.5.1
  • Shellcheck in ci
  • Update CHANGELOG
  • Cygwin jobs
  • macOS jobs (should work ootb, but they hang indefinitely as of 2021.11.15)

@pschmitt pschmitt mentioned this pull request Nov 15, 2021
Closed
@pschmitt
Copy link
Member Author

For some reason, macOS builds are all stuck after the first step.

@alichtman
Copy link
Member

Let's move install.sh out of doc

@pschmitt
Copy link
Member Author

pschmitt commented Nov 15, 2021 •
edited

Let's move install.sh out of doc

Done. I went ahead and moved doc/mod-install.sh along with it to keep things consistent.
They now both reside in scripts/.

alichtman
alichtman requested changes Nov 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
scripts/install.sh Outdated Show resolved Hide resolved
scripts/install.sh Show resolved Hide resolved
@pschmitt pschmitt marked this pull request as ready for review November 15, 2021 20:54
@pschmitt
Copy link
Member Author

FYI: I submarined a ZPLG -> ZINIT sed and replace in the manpage.
428d718

@pschmitt
Copy link
Member Author

pschmitt commented Nov 15, 2021 •
edited

The only thing left here is to pray that in the future the macOS runners work as they should 😕

Edit: and maybe a warning called in check_dependencies

Edit2: done.

@pschmitt pschmitt added enhancement New feature or request packaging Issue related to packaging & distribution labels Nov 15, 2021
@pschmitt pschmitt added this to the zinit 4.0 milestone Nov 15, 2021
alichtman
alichtman reviewed Nov 16, 2021
View reviewed changes
doc/CHANGELOG.md Outdated Show resolved Hide resolved
alichtman
alichtman requested changes Nov 16, 2021
View reviewed changes
scripts/install.sh Show resolved Hide resolved
scripts/install.sh Show resolved Hide resolved
@pschmitt
Copy link
Member Author

GH macOS Runners seem to be fixed now. Enabled macOS jobs.

@alichtman alichtman merged commit 5df5fb6 into master Nov 17, 2021
@alichtman alichtman deleted the installer-ng branch November 17, 2021 08:19
This was referenced Nov 17, 2021
Closed
Merged
@pschmitt pschmitt restored the installer-ng branch November 30, 2021 10:57
@vladdoster vladdoster deleted the installer-ng branch December 27, 2021 10:48
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alichtman alichtman alichtman requested changes

Assignees
No one assigned
Labels
enhancement New feature or request packaging Issue related to packaging & distribution released
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Rewrite the installer
2 participants
@pschmitt @alichtman