Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for eza to use in $ZINIT[LIST_COMMAND] option #636

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vladdoster
Copy link
Member

@vladdoster vladdoster commented Feb 6, 2024

The exa project is unmaintained and development moved the eza fork, but as of 1707207983, eza does not release prebuilt macOS binaries unlike exa. To avoid unnecessarily breaking user configurations, exa has not been removed.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@vladdoster vladdoster changed the title feat: check for eza for LIST_COMMAND option feat: check for eza to use in LIST_COMMAND option Feb 6, 2024
@vladdoster vladdoster changed the title feat: check for eza to use in LIST_COMMAND option feat: check for eza to use in $ZINIT[LIST_COMMAND] option Feb 6, 2024
The `exa` project is unmaintained and development moved the `eza` fork, but as
of 1707207983, `eza` does not release prebuilt macOS binaries unlike `exa`. To
avoid unnecessarily breaking user configurations, `exa` has not been removed.
Comment on lines 66 to +69
if (( ${+commands[exa]} )); then
ZINIT[LIST_COMMAND]='exa --color=always --tree --icons -L3'
elif (( ${+commands[eza]} )); then
ZINIT[LIST_COMMAND]='eza --color=always --tree --icons -L3'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check for eza before exa? If both are installed on the system, we'd probably want to prefer the non-deprecated one.

Suggested change
if (( ${+commands[exa]} )); then
ZINIT[LIST_COMMAND]='exa --color=always --tree --icons -L3'
elif (( ${+commands[eza]} )); then
ZINIT[LIST_COMMAND]='eza --color=always --tree --icons -L3'
if (( ${+commands[eza]} )); then
ZINIT[LIST_COMMAND]='eza --color=always --tree --icons -L3'
elif (( ${+commands[exa]} )); then
ZINIT[LIST_COMMAND]='exa --color=always --tree --icons -L3'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants