Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load annexes from zdharma-continuum repos #7

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

mortenscheel
Copy link
Contributor

No description provided.

@alichtman
Copy link
Member

alichtman commented Nov 1, 2021

tbh I don't fully understand why annexes exist in zinit but LGTM

@alichtman alichtman merged commit d3d6e99 into zdharma-continuum:master Nov 1, 2021
@pschmitt
Copy link
Member

pschmitt commented Nov 1, 2021

These repos do not exist yet, though. Can someone with access create these?

zdharma-continuum/I_WANT_TO_HELP#7
zdharma-continuum/I_WANT_TO_HELP#8

@mortenscheel mortenscheel deleted the patch-1 branch November 1, 2021 13:08
@ryaminal
Copy link

ryaminal commented Nov 1, 2021

tbh I don't fully understand why annexes exist in zinit but LGTM

Annexes are extensions to zinit, yeah? Are you questioning why they aren't just integrated in the core of zinit?

@alichtman
Copy link
Member

alichtman commented Nov 4, 2021

After further thought, I think I get annexes. I don't get the reliance on the zdharma-cointinuum/null repo. That seems like a weird implementation decision.

# Installs rust and then the `lsd' crate and creates the `lsd' shim exposing the binary
zinit ice rustup cargo'!lsd'
zinit load zdharma/null

could just be

# Installs rust and then the `lsd' crate and creates the `lsd' shim exposing the binary
zinit ice rustup cargo'!lsd'

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants